[LinuxBIOS] r2602 - trunk/LinuxBIOSv2/util/getpir

[Uwe Hermann]

On Wed, Apr 11, 2007 at 08:44:43PM +0200, svn at openbios.org wrote:
> Jeremy Jackson wrote:
> I'm guessing nobody has tried compiling it with 64bit userspace?
> 
> Patch makes it compile cleanly and stops a "SEGV instead of working"
> issue.
> 
> I also added a few checks for errors on system calls.
> 
> Signed-off-by: Jeremy Jackson <jerj at coplanar.net>
> 
> Reworked and
> Acked-by: Stefan Reinauer <stepan at coresystems.de>

I think this should either be 

Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>

(sign-off because you modified the code, acked-by because you acked it
and it needs an ack before it can be committed)

or:

You repost the modified patch for review (if your modifications are
nontrivial), with the original sign-off and your new sign-off and
waiting for an ack:

Signed-off-by: Jeremy Jackson <jerj at coplanar.net>
Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

(See also my other post, answering Peter's question from a few days ago)


>  all: getpir checkpir
> +	./checkpir

Don't do this please. If I type 'make' I don't expect the build process
to _run_ the resulting binary for me (won't work anyways as it needs
root access and you usually don't compile as root).


> +irq_tables.c: getpir
> +	./getpir

See above.


> -test:   checkpir
> -	./checkpir ;\
> -	exit 0;

An extra target such as this ('test' or 'run' or so) would be fine, though.

 
Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070411/726d1c12/attachment.sig>