[LinuxBIOS] [PATCH] v3: lar header walk off-by-one

ron minnich rminnich at gmail.com
Wed Sep 26 18:11:37 CEST 2007


On 9/26/07, Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> wrote:
> OK, this patch is not for the weak of hart because it touches some logic
> we had lots of problems with in the past.
> Basically, the lar archive header walk will not see a header at the end
> of the archive if nothing is after that header. However, since a file
> with zero size is a legal lar member, we really can't forbid to look at
> a header terminating the archive.

I need to be convinced that there is any value if having a header for
a zero-length file at the very end of the archive. I think this is way
more capability than we need, and I am very paranoid about LAR, given
the subtle bugs that we have had. Otherwise, I would rather not commit
this.

thanks

ron




More information about the coreboot mailing list