[coreboot] [coreinfo] [PATCH] fix cpu flags overwrite
Stefan Reinauer
stepan at coresystems.de
Fri Sep 26 11:07:59 CEST 2008
Hi Ulf,
Ulf Jordan wrote:
>
>> Index: coreinfo/cpuinfo_module.c
>> ===================================================================
>> --- coreinfo/cpuinfo_module.c (revision 3569)
>> +++ coreinfo/cpuinfo_module.c (working copy)
>> @@ -97,6 +97,7 @@
>> {
>> int i;
>> int lrow = *row;
>> + int output_available=0;
>>
>> wmove(win, lrow, 2);
>>
>> @@ -104,8 +105,10 @@
>> if (flags[i] == NULL)
>> continue;
>>
>> - if (reg & (1 << i))
>> + if (reg & (1 << i)) {
>> wprintw(win, "%s ", flags[i]);
>> + output_available=1;
>> + }
>>
>> if (i && (i % 16) == 0) {
>> lrow++;
>> @@ -113,6 +116,8 @@
>> }
>> }
>>
>> + lrow += output_available;
>> +
>> *row = lrow;
>> }
>>
>> @@ -131,7 +136,7 @@
>>
>> switch (vendor) {
>> case VENDOR_AMD:
>> - wmove(win, lrow++, 1);
>> + wmove(win, lrow, 1);
>> wprintw(win, "AMD Extended Flags: ");
>
> This hunk will make the decoded flags overwrite the heading, please
> remove.
In which case would that happen? The lrow += output_available; part
above prevents this on my system. Does it not work as intended on your
machine?
Stefan
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
More information about the coreboot
mailing list